From: Qing Wang Date: Mon, 18 Oct 2021 11:31:26 +0000 (-0700) Subject: drm/tegra: Switch over to vmemdup_user() X-Git-Tag: v6.6.7~3824^2~10^2~11 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=bbdca2d41b6c9e2ca8e26ad65ec3d7a1fc7ec8db;p=platform%2Fkernel%2Flinux-starfive.git drm/tegra: Switch over to vmemdup_user() This patch fixes the following Coccinelle warning: drivers/gpu/drm/tegra/submit.c:173: WARNING opportunity for vmemdup_user Use vmemdup_user() rather than duplicating its implementation. This is a little bit restricted to reduce false positives. Signed-off-by: Qing Wang Signed-off-by: Thierry Reding --- diff --git a/drivers/gpu/drm/tegra/submit.c b/drivers/gpu/drm/tegra/submit.c index b24738b..84041fc 100644 --- a/drivers/gpu/drm/tegra/submit.c +++ b/drivers/gpu/drm/tegra/submit.c @@ -169,14 +169,9 @@ static void *alloc_copy_user_array(void __user *from, size_t count, size_t size) if (copy_len > 0x4000) return ERR_PTR(-E2BIG); - data = kvmalloc(copy_len, GFP_KERNEL); - if (!data) - return ERR_PTR(-ENOMEM); - - if (copy_from_user(data, from, copy_len)) { - kvfree(data); - return ERR_PTR(-EFAULT); - } + data = vmemdup_user(from, copy_len); + if (IS_ERR(data)) + return ERR_CAST(data); return data; }