From: Rémi Denis-Courmont <remi.denis-courmont@nokia.com>
Date: Mon, 1 Jun 2009 00:35:16 +0000 (+0000)
Subject: Phonet: fix accounting race between gprs_writeable() and gprs_xmit()
X-Git-Tag: v3.0~8655^2~274
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=bbd5898d39ab9f855c732f6f07e40e95b05cf52a;p=platform%2Fkernel%2Flinux-amlogic.git

Phonet: fix accounting race between gprs_writeable() and gprs_xmit()

In the unlikely event that gprs_writeable() and gprs_xmit() check for
writeability at the same, we could stop the device queue forever.

Signed-off-by: Rémi Denis-Courmont <remi.denis-courmont@nokia.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/net/phonet/pep-gprs.c b/net/phonet/pep-gprs.c
index 4aa8885..851f6a3 100644
--- a/net/phonet/pep-gprs.c
+++ b/net/phonet/pep-gprs.c
@@ -212,8 +212,9 @@ static int gprs_xmit(struct sk_buff *skb, struct net_device *dev)
 		dev->stats.tx_bytes += len;
 	}
 
-	if (!pep_writeable(sk))
-		netif_stop_queue(dev);
+	netif_stop_queue(dev);
+	if (pep_writeable(sk))
+		netif_wake_queue(dev);
 	return 0;
 }