From: Joakim Tjernlund Date: Tue, 5 Sep 2017 11:59:43 +0000 (+0200) Subject: powerpc/fsl_pci: Correct fsl_pci_mcheck_exception X-Git-Tag: v5.15~9492^2~54^2~2 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=bb8651e5ce2c23c36998b263272ab2f9203f5a2e;p=platform%2Fkernel%2Flinux-starfive.git powerpc/fsl_pci: Correct fsl_pci_mcheck_exception get_user() had it args reversed causing NIP to be NULL:ed instead of fixing up the PCI access. Note: This still hangs my P1020 Freescale CPU hard, but at least I get a NIP now. Signed-off-by: Joakim Tjernlund Acked-by: Li Yang Signed-off-by: Scott Wood --- diff --git a/arch/powerpc/sysdev/fsl_pci.c b/arch/powerpc/sysdev/fsl_pci.c index 1e57edd..0c524c2 100644 --- a/arch/powerpc/sysdev/fsl_pci.c +++ b/arch/powerpc/sysdev/fsl_pci.c @@ -1070,7 +1070,7 @@ int fsl_pci_mcheck_exception(struct pt_regs *regs) if (is_in_pci_mem_space(addr)) { if (user_mode(regs)) { pagefault_disable(); - ret = get_user(regs->nip, &inst); + ret = get_user(inst, (__u32 __user *)regs->nip); pagefault_enable(); } else { ret = probe_kernel_address((void *)regs->nip, inst);