From: Haavard Skinnemoen Date: Wed, 3 Jun 2009 12:29:16 +0000 (+0200) Subject: avr32: Fix oops on unaligned user access X-Git-Tag: v2.6.31-rc1~346^2 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=bb6e647051a59dca5a72b3deef1e061d7c1c34da;p=profile%2Fivi%2Fkernel-x86-ivi.git avr32: Fix oops on unaligned user access The unaligned address exception handler (and others) does not scan the fixup tables before oopsing. This is bad because it means passing a badly aligned pointer from user space might crash the kernel. Fix this by scanning the fixup tables in _exception(). This should resolve the issue for unaligned addresses as well as other less common exceptions that might be happening during a userspace access. The page fault handler already does fixup processing. Signed-off-by: Haavard Skinnemoen --- diff --git a/arch/avr32/kernel/traps.c b/arch/avr32/kernel/traps.c index d547c8d..6e3d491 100644 --- a/arch/avr32/kernel/traps.c +++ b/arch/avr32/kernel/traps.c @@ -75,8 +75,17 @@ void _exception(long signr, struct pt_regs *regs, int code, { siginfo_t info; - if (!user_mode(regs)) + if (!user_mode(regs)) { + const struct exception_table_entry *fixup; + + /* Are we prepared to handle this kernel fault? */ + fixup = search_exception_tables(regs->pc); + if (fixup) { + regs->pc = fixup->fixup; + return; + } die("Unhandled exception in kernel mode", regs, signr); + } memset(&info, 0, sizeof(info)); info.si_signo = signr;