From: Eric Biggers <ebiggers@google.com>
Date: Sat, 15 Dec 2018 20:41:53 +0000 (-0800)
Subject: crypto: skcipher - add might_sleep() to skcipher_walk_virt()
X-Git-Tag: v5.15~7331^2~3
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=bb648291fc04c49197561939b8bfea0ada42bce3;p=platform%2Fkernel%2Flinux-starfive.git

crypto: skcipher - add might_sleep() to skcipher_walk_virt()

skcipher_walk_virt() can still sleep even with atomic=true, since that
only affects the later calls to skcipher_walk_done().  But,
skcipher_walk_virt() only has to allocate memory for some input data
layouts, so incorrectly calling it with preemption disabled can go
undetected.  Use might_sleep() so that it's detected reliably.

Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
---

diff --git a/crypto/skcipher.c b/crypto/skcipher.c
index 17be8d9..41b4f7f 100644
--- a/crypto/skcipher.c
+++ b/crypto/skcipher.c
@@ -474,6 +474,8 @@ int skcipher_walk_virt(struct skcipher_walk *walk,
 {
 	int err;
 
+	might_sleep_if(req->base.flags & CRYPTO_TFM_REQ_MAY_SLEEP);
+
 	walk->flags &= ~SKCIPHER_WALK_PHYS;
 
 	err = skcipher_walk_skcipher(walk, req);