From: Roland Dreier <roland@purestorage.com>
Date: Wed, 18 Jan 2012 02:00:56 +0000 (-0800)
Subject: target: Return correct ASC for unimplemented VPD pages
X-Git-Tag: upstream/snapshot3+hdmi~7990^2~12
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=bb1acb2ee038a6c13ee99e0b9fb44dacb4a9de84;p=platform%2Fadaptation%2Frenesas_rcar%2Frenesas_kernel.git

target: Return correct ASC for unimplemented VPD pages

My draft of SPC-4 says:

    If the device server does not implement the requested vital product
    data page, then the command shall be terminated with CHECK CONDITION
    status, with the sense key set to ILLEGAL REQUEST, and the
    additional sense code set to INVALID FIELD IN CDB.

Signed-off-by: Roland Dreier <roland@purestorage.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
---

diff --git a/drivers/target/target_core_cdb.c b/drivers/target/target_core_cdb.c
index 07a3025..370ad13 100644
--- a/drivers/target/target_core_cdb.c
+++ b/drivers/target/target_core_cdb.c
@@ -729,7 +729,7 @@ int target_emulate_inquiry(struct se_task *task)
 	}
 
 	pr_err("Unknown VPD Code: 0x%02x\n", cdb[2]);
-	cmd->scsi_sense_reason = TCM_UNSUPPORTED_SCSI_OPCODE;
+	cmd->scsi_sense_reason = TCM_INVALID_CDB_FIELD;
 	ret = -EINVAL;
 
 out_unmap: