From: Johan Hovold Date: Tue, 5 Nov 2019 08:41:45 +0000 (+0100) Subject: USB: legousbtower: stop interrupt-out URB unconditionally X-Git-Tag: v5.15~5055^2~48 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=bafd1b1c2cee5513a400efffa58e9d02d8577423;p=platform%2Fkernel%2Flinux-starfive.git USB: legousbtower: stop interrupt-out URB unconditionally Stop also the interrupt-out URB unconditionally in tower_abort_transfers() which is called from release() (for connected devices). Calling usb_kill_urb() for an idle URB is perfectly fine. Signed-off-by: Johan Hovold Link: https://lore.kernel.org/r/20191105084152.16322-8-johan@kernel.org Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/usb/misc/legousbtower.c b/drivers/usb/misc/legousbtower.c index 33533fa..3e409df 100644 --- a/drivers/usb/misc/legousbtower.c +++ b/drivers/usb/misc/legousbtower.c @@ -448,8 +448,7 @@ static void tower_abort_transfers (struct lego_usb_tower *dev) { /* shutdown transfer */ usb_kill_urb(dev->interrupt_in_urb); - if (dev->interrupt_out_busy) - usb_kill_urb(dev->interrupt_out_urb); + usb_kill_urb(dev->interrupt_out_urb); }