From: Biju Das Date: Fri, 25 Feb 2022 17:53:18 +0000 (+0000) Subject: watchdog: rzg2l_wdt: Add error check for reset_control_deassert X-Git-Tag: v6.6.17~7375^2~25 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=baf1aace9ad15401f08e048a7f1fdec79821bc61;p=platform%2Fkernel%2Flinux-rpi.git watchdog: rzg2l_wdt: Add error check for reset_control_deassert If reset_control_deassert() fails, then we won't be able to access the device registers. Therefore check the return code of reset_control_deassert() and bailout in case of error. Signed-off-by: Biju Das Reviewed-by: Geert Uytterhoeven Reviewed-by: Guenter Roeck Link: https://lore.kernel.org/r/20220225175320.11041-6-biju.das.jz@bp.renesas.com Signed-off-by: Guenter Roeck Signed-off-by: Wim Van Sebroeck --- diff --git a/drivers/watchdog/rzg2l_wdt.c b/drivers/watchdog/rzg2l_wdt.c index 8827470..73b667e 100644 --- a/drivers/watchdog/rzg2l_wdt.c +++ b/drivers/watchdog/rzg2l_wdt.c @@ -203,7 +203,10 @@ static int rzg2l_wdt_probe(struct platform_device *pdev) return dev_err_probe(&pdev->dev, PTR_ERR(priv->rstc), "failed to get cpg reset"); - reset_control_deassert(priv->rstc); + ret = reset_control_deassert(priv->rstc); + if (ret) + return dev_err_probe(dev, ret, "failed to deassert"); + pm_runtime_enable(&pdev->dev); priv->wdev.info = &rzg2l_wdt_ident;