From: Andoni Morales Alastruey <ylatuya@gmail.com>
Date: Mon, 15 Apr 2013 14:32:46 +0000 (+0000)
Subject: osxvideosink: fix segfault accessing osxwindow when not set yet
X-Git-Tag: 1.19.3~509^2~5934
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=baa23d314d3e80ddb7a6071a8cd10aa425081d74;p=platform%2Fupstream%2Fgstreamer.git

osxvideosink: fix segfault accessing osxwindow when not set yet
---

diff --git a/sys/osxvideo/osxvideosink.m b/sys/osxvideo/osxvideosink.m
index 9de76ff..cf939b1 100644
--- a/sys/osxvideo/osxvideosink.m
+++ b/sys/osxvideo/osxvideosink.m
@@ -231,6 +231,7 @@ gst_osx_video_sink_osxwindow_create (GstOSXVideoSink * osxvideosink, gint width,
   osxwindow->width = width;
   osxwindow->height = height;
   osxwindow->closed = FALSE;
+  osxwindow->internal = FALSE;
 
   /* Allocate our GstGLView for the window, and then tell the application
    * about it (hopefully it's listening...) */
@@ -683,11 +684,11 @@ gst_osx_video_sink_set_window_handle (GstVideoOverlay * overlay, guintptr handle
       gst_osx_video_sink_call_from_main_thread(osxvideosink,
         osxvideosink->osxwindow->gstview,
         @selector(addToSuperview:), osxvideosink->superview, YES);
+    if (window_id) {
+      osxvideosink->osxwindow->internal = FALSE;
+    }
   }
 
-  if (window_id) {
-    osxvideosink->osxwindow->internal = FALSE;
-  }
 }
 
 static void