From: Dan Carpenter <error27@gmail.com>
Date: Tue, 24 Jan 2023 15:20:46 +0000 (+0300)
Subject: usb: musb: mediatek: don't unregister something that wasn't registered
X-Git-Tag: v6.6.17~5457^2~81
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=ba883de971d1ad018f3083d9195b8abe54d87407;p=platform%2Fkernel%2Flinux-rpi.git

usb: musb: mediatek: don't unregister something that wasn't registered

This function only calls mtk_otg_switch_init() when the ->port_mode
is MUSB_OTG so the clean up code should only call mtk_otg_switch_exit()
for that mode.

Fixes: 0990366bab3c ("usb: musb: Add support for MediaTek musb controller")
Signed-off-by: Dan Carpenter <error27@gmail.com>
Link: https://lore.kernel.org/r/Y8/3TqpqiSr0RxFH@kili
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---

diff --git a/drivers/usb/musb/mediatek.c b/drivers/usb/musb/mediatek.c
index cad9913..27b9bd2 100644
--- a/drivers/usb/musb/mediatek.c
+++ b/drivers/usb/musb/mediatek.c
@@ -294,7 +294,8 @@ static int mtk_musb_init(struct musb *musb)
 err_phy_power_on:
 	phy_exit(glue->phy);
 err_phy_init:
-	mtk_otg_switch_exit(glue);
+	if (musb->port_mode == MUSB_OTG)
+		mtk_otg_switch_exit(glue);
 	return ret;
 }