From: Ezequiel Garcia Date: Fri, 30 May 2014 16:40:06 +0000 (-0300) Subject: net: mvneta: Fix missing DMA region unmap X-Git-Tag: v3.16-rc1~27^2~94^2~5 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=ba7e46ef9d4550f76efb70739728c50bbf94c3a9;p=platform%2Fkernel%2Flinux-exynos.git net: mvneta: Fix missing DMA region unmap The Tx descriptor release code currently calls dma_unmap_single() and dev_kfree_skb_any() if the descriptor is associated with a non-NULL skb. This is true only for the last fragment of the packet. This is wrong, however, since every descriptor buffer is DMA mapped and needs to be unmapped. Signed-off-by: Ezequiel Garcia Signed-off-by: David S. Miller --- diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net/ethernet/marvell/mvneta.c index 57a2e76..f95e7ca 100644 --- a/drivers/net/ethernet/marvell/mvneta.c +++ b/drivers/net/ethernet/marvell/mvneta.c @@ -1291,11 +1291,10 @@ static void mvneta_txq_bufs_free(struct mvneta_port *pp, mvneta_txq_inc_get(txq); - if (!skb) - continue; - dma_unmap_single(pp->dev->dev.parent, tx_desc->buf_phys_addr, tx_desc->data_size, DMA_TO_DEVICE); + if (!skb) + continue; dev_kfree_skb_any(skb); } }