From: hj kim <backto.kim@samsung.com>
Date: Wed, 17 Jun 2020 07:45:29 +0000 (+0900)
Subject: Improve image_util_transform_create()
X-Git-Tag: submit/tizen/20200622.022343~5
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=ba65c467400c6b88b7b9ced8585117d7ec6d00cf;p=platform%2Fcore%2Fapi%2Fimage-util.git

Improve image_util_transform_create()

g_new0 and g_async_queue_new_full not return NULL.

Change-Id: I67459034e4693817776b5c3030a5c453399925af
---

diff --git a/src/image_util.c b/src/image_util.c
index b6f6f8f..6b9fd7e 100644
--- a/src/image_util.c
+++ b/src/image_util.c
@@ -197,8 +197,7 @@ int image_util_transform_create(transformation_h * handle)
 
 	image_util_retvm_if(!handle, IMAGE_UTIL_ERROR_INVALID_PARAMETER, "Invalid Handle");
 
-	transformation_s *_handle = (transformation_s *) calloc(1, sizeof(transformation_s));
-	image_util_retvm_if((_handle == NULL), IMAGE_UTIL_ERROR_OUT_OF_MEMORY, "OUT_OF_MEMORY");
+	transformation_s *_handle = g_new0(transformation_s, 1);
 
 	/* private values init */
 	_handle->color = MM_UTIL_COLOR_NUM;
@@ -216,10 +215,6 @@ int image_util_transform_create(transformation_h * handle)
 
 	/* The queue is a communicator for thread */
 	_handle->queue = g_async_queue_new_full(__destroy_async_queue);
-	if (!_handle->queue) {
-		image_util_error("g_async_queue_new failed");
-		goto Error;
-	}
 
 	/* create thread */
 	_handle->thread = g_thread_new("transform_thread", __transform_thread, (gpointer)_handle->queue);
@@ -227,15 +222,6 @@ int image_util_transform_create(transformation_h * handle)
 	*handle = (transformation_h) _handle;
 
 	return IMAGE_UTIL_ERROR_NONE;
-
-Error:
-	if (_handle->queue)
-		g_async_queue_unref(_handle->queue);
-	if (_handle->thread)
-		g_thread_unref(_handle->thread);
-	IMAGE_UTIL_SAFE_FREE(_handle);
-
-	return IMAGE_UTIL_ERROR_INVALID_OPERATION;
 }
 
 int image_util_transform_set_hardware_acceleration(transformation_h handle, bool mode)
@@ -487,7 +473,7 @@ int image_util_transform_destroy(transformation_h handle)
 		_handle->queue = NULL;
 	}
 
-	IMAGE_UTIL_SAFE_FREE(_handle);
+	IMAGE_UTIL_SAFE_G_FREE(_handle);
 
 	image_util_fleave();