From: Sebastian Hesselbarth Date: Mon, 26 Nov 2012 19:16:39 +0000 (+0100) Subject: pinctrl: mvebu: make pdma clock on dove mandatory X-Git-Tag: upstream/snapshot3+hdmi~5604^2~61^2~10 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=ba607b6238a1f418c45b9d7f73212bcc6922da53;p=platform%2Fadaptation%2Frenesas_rcar%2Frenesas_kernel.git pinctrl: mvebu: make pdma clock on dove mandatory With the ability to pass clocks through DT, now make the pdma clock of dove pinctrl mandatory. Otherwise, pinctrl will hang the system when accessing some registers. Signed-off-by: Sebastian Hesselbarth Signed-off-by: Jason Cooper --- diff --git a/drivers/pinctrl/mvebu/pinctrl-dove.c b/drivers/pinctrl/mvebu/pinctrl-dove.c index 40c9c3e..9cc219f 100644 --- a/drivers/pinctrl/mvebu/pinctrl-dove.c +++ b/drivers/pinctrl/mvebu/pinctrl-dove.c @@ -595,8 +595,11 @@ static int __devinit dove_pinctrl_probe(struct platform_device *pdev) * grab clk to make sure it is ticking. */ clk = devm_clk_get(&pdev->dev, NULL); - if (!IS_ERR(clk)) - clk_prepare_enable(clk); + if (IS_ERR(clk)) { + dev_err(&pdev->dev, "Unable to get pdma clock"); + return PTR_RET(clk); + } + clk_prepare_enable(clk); return mvebu_pinctrl_probe(pdev); }