From: Shea Levy <shea@shealevy.com>
Date: Sat, 24 Sep 2011 17:32:13 +0000 (-0400)
Subject: passphrase_read: Overwrite possible references to passphrase data in local stack... 
X-Git-Tag: 1.0-beta1~115^2~2^2~15
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=ba33f0eed740cc1433d599b6c39cbec857973f29;p=platform%2Fupstream%2Ffreerdp.git

passphrase_read: Overwrite possible references to passphrase data in local stack frame before any potential return

Also, accidentally included termios.h here, should have been at next commit
---

diff --git a/libfreerdp-utils/passphrase.c b/libfreerdp-utils/passphrase.c
index 58b3e20..57efc06 100644
--- a/libfreerdp-utils/passphrase.c
+++ b/libfreerdp-utils/passphrase.c
@@ -22,6 +22,7 @@
 #include <stdio.h>
 #include <string.h>
 #include <sys/stat.h>
+#include <termios.h>
 #include <unistd.h>
 #include <freerdp/utils/passphrase.h>
 
@@ -60,10 +61,11 @@ char* freerdp_passphrase_read(const char* prompt, char* buf, size_t bufsiz)
 			buf_iter++;
 		}
 	}
-	if (nbytes == (ssize_t) -1)
-		return NULL;
 	*buf_iter = '\0';
 	buf_iter = NULL;
+	read_char = '\0';
+	if (nbytes == (ssize_t) -1)
+		return NULL;
 
 	if (close(term_id) == -1)
 		return NULL;