From: Kazu Hirata Date: Tue, 16 Feb 2021 21:17:33 +0000 (-0800) Subject: [SampleFDO] Provide a virtual desructor for SampleProfileLoaderBaseImpl X-Git-Tag: llvmorg-14-init~14961 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=ba2aa5f49ebbe28ad2dbf0c5bea451f0ebf436c6;p=platform%2Fupstream%2Fllvm.git [SampleFDO] Provide a virtual desructor for SampleProfileLoaderBaseImpl This patch fixes a warning: llvm-project/llvm/include/llvm/ProfileData/SampleProfileLoaderBaseImpl.h:69:7: error: 'llvm::SampleProfileLoaderBaseImpl' has virtual functions but non-virtual destructor [-Werror,-Wnon-virtual-dtor] Differential Revision: https://reviews.llvm.org/D96810 --- diff --git a/llvm/include/llvm/ProfileData/SampleProfileLoaderBaseImpl.h b/llvm/include/llvm/ProfileData/SampleProfileLoaderBaseImpl.h index f02bacb..0345496 100644 --- a/llvm/include/llvm/ProfileData/SampleProfileLoaderBaseImpl.h +++ b/llvm/include/llvm/ProfileData/SampleProfileLoaderBaseImpl.h @@ -69,6 +69,7 @@ extern cl::opt NoWarnSampleUnused; class SampleProfileLoaderBaseImpl { public: SampleProfileLoaderBaseImpl(std::string Name) : Filename(Name) {} + virtual ~SampleProfileLoaderBaseImpl() = default; void dump() { Reader->dump(); } protected: