From: Christoph Hellwig Date: Fri, 2 Dec 2022 10:26:40 +0000 (+0100) Subject: hfs: remove ->writepage X-Git-Tag: v6.6.17~5931^2~22 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=ba195d9f14829690b8e4f67549960d83169a314e;p=platform%2Fkernel%2Flinux-rpi.git hfs: remove ->writepage ->writepage is a very inefficient method to write back data, and only used through write_cache_pages or a a fallback when no ->migrate_folio method is present. Set ->migrate_folio to the generic buffer_head based helper, and stop wiring up ->writepage for hfs_aops. Link: https://lkml.kernel.org/r/20221202102644.770505-4-hch@lst.de Signed-off-by: Christoph Hellwig Acked-by: Johannes Weiner Signed-off-by: Andrew Morton --- diff --git a/fs/hfs/inode.c b/fs/hfs/inode.c index c4526f1..16466a5 100644 --- a/fs/hfs/inode.c +++ b/fs/hfs/inode.c @@ -173,12 +173,12 @@ const struct address_space_operations hfs_aops = { .dirty_folio = block_dirty_folio, .invalidate_folio = block_invalidate_folio, .read_folio = hfs_read_folio, - .writepage = hfs_writepage, .write_begin = hfs_write_begin, .write_end = generic_write_end, .bmap = hfs_bmap, .direct_IO = hfs_direct_IO, .writepages = hfs_writepages, + .migrate_folio = buffer_migrate_folio, }; /*