From: lucas <lucas@7cbeb6ba-43b4-40fd-8cce-4c39aea84d33>
Date: Thu, 26 Aug 2010 20:45:09 +0000 (+0000)
Subject: Apply double_condition_check.cocci
X-Git-Tag: submit/trunk/20120815.174732~2481
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=ba0995c5c85f458453716e9884bb404d372ba96b;p=profile%2Fivi%2Fevas.git

Apply double_condition_check.cocci

The offending projects were:

 E16/e/src/backgrounds.c                 |   10 ++++------
 PROTO/eon/src/lib/layout/eon_stack.c    |    4 +---
 ecore/src/lib/ecore_win32/ecore_win32.c |    3 +--
 ecore/src/lib/ecore_wince/ecore_wince.c |    3 +--
 edje/src/lib/edje_edit.c                |    3 +--
 evas/src/lib/cache/evas_cache_image.c   |    2 +-
 exalt/src/lib/libexalt_private.c        |    2 +-


This patch assumes code in these places were insane and the fix is to remove
one condition check. Most likely this is not true, but there's no automatic fix
for that.

Looking at the patch, it seems that some places should use "x" and "y" vars but
used just one of them and therefore they were caught by coccinelle.




git-svn-id: http://svn.enlightenment.org/svn/e/trunk/evas@51666 7cbeb6ba-43b4-40fd-8cce-4c39aea84d33
---

diff --git a/src/lib/cache/evas_cache_image.c b/src/lib/cache/evas_cache_image.c
index bba2691..9c47946 100644
--- a/src/lib/cache/evas_cache_image.c
+++ b/src/lib/cache/evas_cache_image.c
@@ -727,7 +727,7 @@ evas_cache_image_request(Evas_Cache_Image *cache, const char *file, const char *
         (lo->scale_down_by == 0) &&
         (lo->dpi == 0.0) &&
         ((lo->w == 0) || (lo->h == 0)) &&
-        ((lo->region.w == 0) || (lo->region.w == 0))
+        ((lo->region.w == 0))
         ))
      {
         lo = &prevent;