From: Mauro Carvalho Chehab Date: Wed, 5 Nov 2014 11:34:12 +0000 (-0200) Subject: [media] stb0899: don't go past DiSEqC msg buffer X-Git-Tag: v5.15~16478^2~223 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=b9f62ffe05e4019da205d6fec244226b191c5242;p=platform%2Fkernel%2Flinux-starfive.git [media] stb0899: don't go past DiSEqC msg buffer As reported by spatch: drivers/media/dvb-frontends/stb0899_drv.c:720 stb0899_send_diseqc_msg() error: buffer overflow 'cmd->msg' 6 <= 7 The buffer size is 6 and not 8. Anyway, the best is to use sizeof(), to avoid such mistakes. Signed-off-by: Mauro Carvalho Chehab --- diff --git a/drivers/media/dvb-frontends/stb0899_drv.c b/drivers/media/dvb-frontends/stb0899_drv.c index 07cd5ea..19646fb 100644 --- a/drivers/media/dvb-frontends/stb0899_drv.c +++ b/drivers/media/dvb-frontends/stb0899_drv.c @@ -705,7 +705,7 @@ static int stb0899_send_diseqc_msg(struct dvb_frontend *fe, struct dvb_diseqc_ma struct stb0899_state *state = fe->demodulator_priv; u8 reg, i; - if (cmd->msg_len > 8) + if (cmd->msg_len > sizeof(cmd->msg)) return -EINVAL; /* enable FIFO precharge */