From: Ivan Maidanski Date: Tue, 25 Oct 2016 21:14:20 +0000 (+0300) Subject: Eliminate 'Condition 0==datastart always false' cppcheck warning (dyn_load) X-Git-Tag: v8.0.0~1075 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=b9f46e5af3700ea60d93394a467071042ba5fb33;p=platform%2Fupstream%2Flibgc.git Eliminate 'Condition 0==datastart always false' cppcheck warning (dyn_load) * dyn_load.c [HAVE_DL_ITERATE_PHDR] (GC_register_dynamic_libraries_dl_iterate_phdr): Cast datastart to char*volatile* before dereferencing and checking against NULL. --- diff --git a/dyn_load.c b/dyn_load.c index 836e4bc..42534c1 100644 --- a/dyn_load.c +++ b/dyn_load.c @@ -621,7 +621,8 @@ STATIC GC_bool GC_register_dynamic_libraries_dl_iterate_phdr(void) # else dataend = DATAEND; # endif - if (NULL == datastart || (word)datastart > (word)dataend) + if (NULL == *(char * volatile *)&datastart + || (word)datastart > (word)dataend) ABORT_ARG2("Wrong DATASTART/END pair", ": %p .. %p", (void *)datastart, (void *)dataend);