From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Mon, 27 Aug 2018 09:23:01 +0000 (+0300)
Subject: scsi: aacraid: fix a signedness bug
X-Git-Tag: v4.19~80^2~15
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=b9eb3b14f1dbf16bf27b6c1ffe6b8c00ec945c9b;p=platform%2Fkernel%2Flinux-rpi.git

scsi: aacraid: fix a signedness bug

The problem is that ->reset_state is a u8 but it can be set to -1 or -2 in
aac_tmf_callback() and the error handling in aac_eh_target_reset() relies
on it to be signed.

[mkp: fixed typo]

Fixes: 0d643ff3c353 ("scsi: aacraid: use aac_tmf_callback for reset fib")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
---

diff --git a/drivers/scsi/aacraid/aacraid.h b/drivers/scsi/aacraid/aacraid.h
index 29bf1e6..39eb415 100644
--- a/drivers/scsi/aacraid/aacraid.h
+++ b/drivers/scsi/aacraid/aacraid.h
@@ -1346,7 +1346,7 @@ struct fib {
 struct aac_hba_map_info {
 	__le32	rmw_nexus;		/* nexus for native HBA devices */
 	u8		devtype;	/* device type */
-	u8		reset_state;	/* 0 - no reset, 1..x - */
+	s8		reset_state;	/* 0 - no reset, 1..x - */
 					/* after xth TM LUN reset */
 	u16		qd_limit;
 	u32		scan_counter;