From: Alexey Khoroshilov Date: Thu, 6 Sep 2018 22:16:54 +0000 (+0300) Subject: spi: pic32: remove unnecessary of_node_get() X-Git-Tag: v5.15~7532^2~63 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=b9a947dd756b7af84ababa57e0524788f91a5382;p=platform%2Fkernel%2Flinux-starfive.git spi: pic32: remove unnecessary of_node_get() Almost all spi drivers assign spi master->dev.of_node from its parent platform device without additional refcounting. It seems of_node_get() in pic32_spi_probe() is unnecessary and there is no corresponding of_node_put(). Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov Signed-off-by: Mark Brown --- diff --git a/drivers/spi/spi-pic32.c b/drivers/spi/spi-pic32.c index f8a45af..46ff761 100644 --- a/drivers/spi/spi-pic32.c +++ b/drivers/spi/spi-pic32.c @@ -774,7 +774,7 @@ static int pic32_spi_probe(struct platform_device *pdev) if (ret) goto err_master; - master->dev.of_node = of_node_get(pdev->dev.of_node); + master->dev.of_node = pdev->dev.of_node; master->mode_bits = SPI_MODE_3 | SPI_MODE_0 | SPI_CS_HIGH; master->num_chipselect = 1; /* single chip-select */ master->max_speed_hz = clk_get_rate(pic32s->clk);