From: YueHaibing <yuehaibing@huawei.com>
Date: Thu, 19 Jul 2018 02:27:13 +0000 (+0800)
Subject: net: caif: Add a missing rcu_read_unlock() in caif_flow_cb
X-Git-Tag: v4.14.68~134
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=b970d8a1c213d8f030feddb3cbf934df4302eb47;p=platform%2Fkernel%2Flinux-exynos.git

net: caif: Add a missing rcu_read_unlock() in caif_flow_cb

[ Upstream commit 64119e05f7b31e83e2555f6782e6cdc8f81c63f4 ]

Add a missing rcu_read_unlock in the error path

Fixes: c95567c80352 ("caif: added check for potential null return")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---

diff --git a/net/caif/caif_dev.c b/net/caif/caif_dev.c
index 2d38b6e..98b62a7 100644
--- a/net/caif/caif_dev.c
+++ b/net/caif/caif_dev.c
@@ -131,8 +131,10 @@ static void caif_flow_cb(struct sk_buff *skb)
 	caifd = caif_get(skb->dev);
 
 	WARN_ON(caifd == NULL);
-	if (caifd == NULL)
+	if (!caifd) {
+		rcu_read_unlock();
 		return;
+	}
 
 	caifd_hold(caifd);
 	rcu_read_unlock();