From: Simon Marchi <simon.marchi@polymtl.ca>
Date: Sat, 3 Mar 2018 04:27:46 +0000 (-0500)
Subject: handle_general_set: Remove useless xstrdup
X-Git-Tag: binutils-2_31~1137
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=b9671caf8fe1abd737846edf7dcd627870f986cc;p=external%2Fbinutils.git

handle_general_set: Remove useless xstrdup

Unless I'm missing something very obvious, this xstrdup seems
unnecessary to me.  We can pass "mode" directly to sprintf.

gdb/gdbserver/ChangeLog:

	* server.c (handle_general_set): Remove unnecessary xstrdup.
---

diff --git a/gdb/gdbserver/ChangeLog b/gdb/gdbserver/ChangeLog
index 70a9387..f7de928 100644
--- a/gdb/gdbserver/ChangeLog
+++ b/gdb/gdbserver/ChangeLog
@@ -1,5 +1,9 @@
 2018-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
 
+	* server.c (handle_general_set): Remove unnecessary xstrdup.
+
+2018-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
+
 	* server.c (parse_debug_format_options): Adjust to
 	delim_string_to_char_ptr_vec changes.
 	* thread-db.c (thread_db_load_search): Adjust to
diff --git a/gdb/gdbserver/server.c b/gdb/gdbserver/server.c
index afdd504..64c72bd 100644
--- a/gdb/gdbserver/server.c
+++ b/gdb/gdbserver/server.c
@@ -847,12 +847,9 @@ handle_general_set (char *own_buf)
 	req = TRIBOOL_TRUE;
       else
 	{
-	  char *mode_copy = xstrdup (mode);
-
 	  /* We don't know what this mode is, so complain to GDB.  */
 	  sprintf (own_buf, "E.Unknown thread-events mode requested: %s\n",
-		   mode_copy);
-	  xfree (mode_copy);
+		   mode);
 	  return;
 	}