From: Ondrej Mosnacek Date: Thu, 13 Sep 2018 08:51:31 +0000 (+0200) Subject: crypto: lrw - Fix out-of bounds access on counter overflow X-Git-Tag: v4.9.137~47 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=b957cd4d7de6892a35a66c1cf7b5199aafe1b2c9;p=platform%2Fkernel%2Flinux-amlogic.git crypto: lrw - Fix out-of bounds access on counter overflow commit fbe1a850b3b1522e9fc22319ccbbcd2ab05328d2 upstream. When the LRW block counter overflows, the current implementation returns 128 as the index to the precomputed multiplication table, which has 128 entries. This patch fixes it to return the correct value (127). Fixes: 64470f1b8510 ("[CRYPTO] lrw: Liskov Rivest Wagner, a tweakable narrow block cipher mode") Cc: # 2.6.20+ Reported-by: Eric Biggers Signed-off-by: Ondrej Mosnacek Signed-off-by: Herbert Xu Signed-off-by: Greg Kroah-Hartman --- diff --git a/crypto/lrw.c b/crypto/lrw.c index 6f9908a..d38a382 100644 --- a/crypto/lrw.c +++ b/crypto/lrw.c @@ -132,7 +132,12 @@ static inline int get_index128(be128 *block) return x + ffz(val); } - return x; + /* + * If we get here, then x == 128 and we are incrementing the counter + * from all ones to all zeros. This means we must return index 127, i.e. + * the one corresponding to key2*{ 1,...,1 }. + */ + return 127; } static int crypt(struct blkcipher_desc *d,