From: Srinivasan Shanmugam Date: Fri, 30 Jun 2023 15:32:50 +0000 (+0530) Subject: drm/amdgpu: Remove else after return statement in 'gmc_v8_0_check_soft_reset' X-Git-Tag: v6.6.17~3937^2~20^2~184 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=b8f68f1da50e1e117dff704fa55602f999539598;p=platform%2Fkernel%2Flinux-rpi.git drm/amdgpu: Remove else after return statement in 'gmc_v8_0_check_soft_reset' Fix below checkpatch warnings: WARNING: else is not generally useful after a break or return + return true; + } else { Cc: Christian König Cc: Alex Deucher Signed-off-by: Srinivasan Shanmugam Acked-by: Christian König Signed-off-by: Alex Deucher --- diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c b/drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c index 581ed92..21cb97b 100644 --- a/drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c +++ b/drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c @@ -1319,13 +1319,15 @@ static bool gmc_v8_0_check_soft_reset(void *handle) srbm_soft_reset = REG_SET_FIELD(srbm_soft_reset, SRBM_SOFT_RESET, SOFT_RESET_MC, 1); } + if (srbm_soft_reset) { adev->gmc.srbm_soft_reset = srbm_soft_reset; return true; - } else { - adev->gmc.srbm_soft_reset = 0; - return false; } + + adev->gmc.srbm_soft_reset = 0; + + return false; } static int gmc_v8_0_pre_soft_reset(void *handle)