From: Bill Wendling Date: Thu, 9 Jun 2022 22:16:31 +0000 (+0000) Subject: netfilter: conntrack: use correct format characters X-Git-Tag: v6.1-rc5~731^2~97^2~16 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=b8acd43148c067376f76faed9be138aa0e25414c;p=platform%2Fkernel%2Flinux-starfive.git netfilter: conntrack: use correct format characters When compiling with -Wformat, clang emits the following warnings: net/netfilter/nf_conntrack_helper.c:168:18: error: format string is not a string literal (potentially insecure) [-Werror,-Wformat-security] request_module(mod_name); ^~~~~~~~ Use a string literal for the format string. Link: https://github.com/ClangBuiltLinux/linux/issues/378 Signed-off-by: Bill Wendling Signed-off-by: Pablo Neira Ayuso --- diff --git a/net/netfilter/nf_conntrack_helper.c b/net/netfilter/nf_conntrack_helper.c index c12a87e..1e0424d 100644 --- a/net/netfilter/nf_conntrack_helper.c +++ b/net/netfilter/nf_conntrack_helper.c @@ -165,7 +165,7 @@ nf_nat_helper_try_module_get(const char *name, u16 l3num, u8 protonum) if (!nat) { snprintf(mod_name, sizeof(mod_name), "%s", h->nat_mod_name); rcu_read_unlock(); - request_module(mod_name); + request_module("%s", mod_name); rcu_read_lock(); nat = nf_conntrack_nat_helper_find(mod_name);