From: Markus Elfring Date: Fri, 11 Aug 2017 14:04:53 +0000 (+0200) Subject: ASoC: dwc: Delete an error message for a failed memory allocation in dw_i2s_probe() X-Git-Tag: v4.14-rc4~21^2~23^2~11^2 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=b88845484d05c2910ffc40a7d30fa36e58b2dd0d;p=platform%2Fkernel%2Flinux-exynos.git ASoC: dwc: Delete an error message for a failed memory allocation in dw_i2s_probe() Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf Signed-off-by: Markus Elfring Signed-off-by: Mark Brown --- diff --git a/sound/soc/dwc/dwc-i2s.c b/sound/soc/dwc/dwc-i2s.c index eebe9d3..e27e21f 100644 --- a/sound/soc/dwc/dwc-i2s.c +++ b/sound/soc/dwc/dwc-i2s.c @@ -617,10 +617,8 @@ static int dw_i2s_probe(struct platform_device *pdev) const char *clk_id; dev = devm_kzalloc(&pdev->dev, sizeof(*dev), GFP_KERNEL); - if (!dev) { - dev_warn(&pdev->dev, "kzalloc fail\n"); + if (!dev) return -ENOMEM; - } dw_i2s_dai = devm_kzalloc(&pdev->dev, sizeof(*dw_i2s_dai), GFP_KERNEL); if (!dw_i2s_dai)