From: Shannon Nelson Date: Wed, 21 Oct 2015 23:47:03 +0000 (-0400) Subject: i40e: Change BUG_ON to WARN_ON in service event complete X-Git-Tag: v4.5-rc1~128^2~246^2~12 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=b875f99b4cb454e0aa1e68d2d8792112a1e07050;p=platform%2Fkernel%2Flinux-exynos.git i40e: Change BUG_ON to WARN_ON in service event complete There's no need to kill the thread and eventually the kernel in this case. In fact, the remainder of the code won't hurt anything anyway, so just complain that we're here and move along. Prompted by a recent Linus diatribe. Change-ID: Iec020d8bcfedffc1cd2553cc6905fd915bb3e670 Signed-off-by: Shannon Nelson Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c index b825f97..7715c54 100644 --- a/drivers/net/ethernet/intel/i40e/i40e_main.c +++ b/drivers/net/ethernet/intel/i40e/i40e_main.c @@ -5738,7 +5738,7 @@ static void i40e_handle_lan_overflow_event(struct i40e_pf *pf, **/ static void i40e_service_event_complete(struct i40e_pf *pf) { - BUG_ON(!test_bit(__I40E_SERVICE_SCHED, &pf->state)); + WARN_ON(!test_bit(__I40E_SERVICE_SCHED, &pf->state)); /* flush memory to make sure state is correct before next watchog */ smp_mb__before_atomic();