From: Jeongmo Yang <jm80.yang@samsung.com>
Date: Tue, 6 Jul 2021 08:01:12 +0000 (+0900)
Subject: Fix coverity issue - Unchecked return value
X-Git-Tag: submit/tizen/20210706.083607^0
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=b84c4296ec0c195202684e5ecec8cda488bc50a6;p=platform%2Fcore%2Fapi%2Fmediacodec.git

Fix coverity issue - Unchecked return value

[Version] 0.6.18
[Issue Type] Coverity

Change-Id: I335336489d9e0781c47541b4fa13ca71c1980083
Signed-off-by: Jeongmo Yang <jm80.yang@samsung.com>
---

diff --git a/packaging/capi-media-codec.spec b/packaging/capi-media-codec.spec
index db1277c..1c1d0ba 100644
--- a/packaging/capi-media-codec.spec
+++ b/packaging/capi-media-codec.spec
@@ -4,7 +4,7 @@
 
 Name:       capi-media-codec
 Summary:    A Media Codec library in Tizen Native API
-Version:    0.6.17
+Version:    0.6.18
 Release:    0
 Group:      Multimedia/API
 License:    Apache-2.0
diff --git a/src/media_codec_port_gst.c b/src/media_codec_port_gst.c
index 6465c59..9455e22 100644
--- a/src/media_codec_port_gst.c
+++ b/src/media_codec_port_gst.c
@@ -2474,26 +2474,24 @@ GstMCBuffer *__mc_gst_make_media_packet(mc_gst_core_t *core, GstBuffer *buffer)
 	void *data = NULL;
 	gint size = 0;
 
-
-	mcbuffer = (GstMCBuffer *)g_malloc0(sizeof(*mcbuffer));
-
-	if (mcbuffer == NULL) {
-		LOGE("malloc fail");
-		return NULL;
-	}
-
 	mem = gst_buffer_peek_memory(buffer, 0);
 
 	if (gst_is_tizen_memory(mem)) {
 		data = (void *)gst_tizen_memory_get_surface(mem);
 		size = tbm_surface_internal_get_size((tbm_surface_h)data);
 	} else {
-		gst_memory_map(mem, &map, GST_MAP_READ);
+		if (!gst_memory_map(mem, &map, GST_MAP_READ)) {
+			LOGE("gst_memory_map failed for buffer[%p]", buffer);
+			return NULL;
+		}
+
 		data = map.data;
 		size = map.size;
 		gst_memory_unmap(mem, &map);
 	}
 
+	mcbuffer = g_new0(GstMCBuffer, 1);
+
 	mcbuffer->buffer = buffer;
 	mcbuffer->core = core;
 	mcbuffer->buf_size = size;