From: Kamil Lysik <k.lysik@samsung.com>
Date: Tue, 17 Mar 2015 14:40:44 +0000 (+0100)
Subject: [SystemSettings] Proper error handling
X-Git-Tag: submit/tizen_tv/20150603.064601~1^2~268
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=b846f3c02251a02614d9cd77ff15ab890834f84c;p=platform%2Fcore%2Fapi%2Fwebapi-plugins.git

[SystemSettings] Proper error handling

This module handled errors in invalid way.
Module should invoke util's getErrorObject.

This commit is required to Tizen TCT.

Change-Id: I73520b58d1800be74034ef3a1cbec8ae919d8678
Signed-off-by: Kamil Lysik <k.lysik@samsung.com>
---

diff --git a/src/systemsetting/systemsetting_api.js b/src/systemsetting/systemsetting_api.js
index 50c0134b..7cf25edc 100644
--- a/src/systemsetting/systemsetting_api.js
+++ b/src/systemsetting/systemsetting_api.js
@@ -35,10 +35,8 @@ SystemSettingManager.prototype.getProperty = function() {
     ]);
 
     var callback = function(result) {
-        if (result.status === 'error') {
-            if (!type_.isNullOrUndefined(args.errorCallback)) {
-                args.errorCallback(result.error);
-            }
+        if (native_.isFailure(result)) {
+            native_.callIfPossible(args.errorCallback, native_.getErrorObject(result));
         }
         else {
             args.successCallback(result.result.value);
@@ -61,10 +59,8 @@ SystemSettingManager.prototype.setProperty = function() {
     ]);
 
     var callback = function(result) {
-        if (result.status === 'error') {
-            if (!type_.isNullOrUndefined(args.errorCallback)) {
-                args.errorCallback(result.error);
-            }
+        if (native_.isFailure(result)) {
+            native_.callIfPossible(args.errorCallback, native_.getErrorObject(result));
         }
         else {
             args.successCallback();