From: Mike Gorse <mgorse@novell.com>
Date: Thu, 29 Dec 2011 14:23:10 +0000 (-0600)
Subject: Warn if a device listener returns a non-bool, rather than crash
X-Git-Tag: AT_SPI2_CORE_2_3_4~4
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=b7bbc86a845270ffa1597ff8b5c9231eebddd512;p=platform%2Fupstream%2Fat-spi2-core.git

Warn if a device listener returns a non-bool, rather than crash
---

diff --git a/atspi/atspi-device-listener.c b/atspi/atspi-device-listener.c
index 1e68eb1..58a6d6a 100644
--- a/atspi/atspi-device-listener.c
+++ b/atspi/atspi-device-listener.c
@@ -389,6 +389,11 @@ _atspi_dbus_handle_DeviceEvent (DBusConnection *bus, DBusMessage *message, void
   if (klass->device_event)
   {
     retval = (*klass->device_event) (listener, &event);
+    if (retval != 0 && retval != 1)
+    {
+      g_warning ("at-spi: device event handler returned %d; should be 0 or 1", retval);
+      retval = 0;
+    }
   }
 done:
   reply = dbus_message_new_method_return (message);