From: Charles Giessen <charles@lunarg.com>
Date: Mon, 23 Oct 2023 20:44:56 +0000 (-0600)
Subject: Dont assert in vkAllocateCommandBuffers
X-Git-Tag: upstream/1.3.296~190
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=b765f768d97fcdd0c0e9fcbb58e7038344bb2027;p=platform%2Fupstream%2FVulkan-Loader.git

Dont assert in vkAllocateCommandBuffers

The loader_init_dispatch first checks if the dispatchable handle has the
ICD_MAGIC_VALUE before setting the handle to the correct dispatch pointer.
This is useful to check that driver's are correctly creating the handle
using VK_LOADER_DATA.

Because layers are capable of wrapping handles, the loader_init_dispatch
function should only be called in terminators which run before any layers
have a chance to modify the ICD_MAGIC_VALUE. Otherwise the assert fails.

vkGetDeviceQueue & vkGetDeviceQueue2 uses loader_set_dispatch, which does
the same code as loader_init_dispatch but without the assert.

This commit changes vkAllocateCommandBuffers to use loader_set_dispatch.
---

diff --git a/loader/trampoline.c b/loader/trampoline.c
index 65809efb..cd3160dc 100644
--- a/loader/trampoline.c
+++ b/loader/trampoline.c
@@ -1933,7 +1933,7 @@ LOADER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkAllocateCommandBuffers(VkDevice d
     if (res == VK_SUCCESS) {
         for (uint32_t i = 0; i < pAllocateInfo->commandBufferCount; i++) {
             if (pCommandBuffers[i]) {
-                loader_init_dispatch(pCommandBuffers[i], disp);
+                loader_set_dispatch(pCommandBuffers[i], disp);
             }
         }
     }