From: Kelvin Cao Date: Fri, 19 Nov 2021 00:38:03 +0000 (-0800) Subject: PCI/switchtec: Declare local state_names[] as static X-Git-Tag: v6.1-rc5~2209^2~21^2 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=b76521f6482d2a2a691e4eb1a496d55d73aea064;p=platform%2Fkernel%2Flinux-starfive.git PCI/switchtec: Declare local state_names[] as static The local state_names[] array is constant and need not be allocated and populated each time we enter stuser_set_state(). Declare it as static. See the link below for the discussion. https://lore.kernel.org/r/20211014141859.11444-1-kelvin.cao@microchip.com/ [bhelgaas: simplify commit log] Suggested-by: Krzysztof Wilczyński Link: https://lore.kernel.org/r/20211119003803.2333-3-kelvin.cao@microchip.com Signed-off-by: Kelvin Cao Signed-off-by: Bjorn Helgaas Reviewed-by: Logan Gunthorpe --- diff --git a/drivers/pci/switch/switchtec.c b/drivers/pci/switch/switchtec.c index 6e2d6c5..c36c123 100644 --- a/drivers/pci/switch/switchtec.c +++ b/drivers/pci/switch/switchtec.c @@ -122,7 +122,7 @@ static void stuser_set_state(struct switchtec_user *stuser, { /* requires the mrpc_mutex to already be held when called */ - const char * const state_names[] = { + static const char * const state_names[] = { [MRPC_IDLE] = "IDLE", [MRPC_QUEUED] = "QUEUED", [MRPC_RUNNING] = "RUNNING",