From: Igor Mammedov Date: Mon, 5 May 2014 20:49:49 +0000 (+0200) Subject: ACPI / processor: do not mark present at boot but not onlined CPU as onlined X-Git-Tag: v3.12.22~20 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=b71f54081b56e0fa7d838626c88cdf2d9bba5359;p=platform%2Fkernel%2Flinux-stable.git ACPI / processor: do not mark present at boot but not onlined CPU as onlined commit 0b9d46dd7debf8e6dc8614106f1c1909fa8de64d upstream. acpi_processor_add() assumes that present at boot CPUs are always onlined, it is not so if a CPU failed to become onlined. As result acpi_processor_add() will mark such CPU device as onlined in sysfs and following attempts to online/offline it using /sys/device/system/cpu/cpuX/online attribute will fail. Do not poke into device internals in acpi_processor_add() and touch "struct device { .offline }" attribute, since for CPUs onlined at boot it's set by: topology_init() -> arch_register_cpu() -> register_cpu() before ACPI device tree is parsed, and for hotplugged CPUs it's set when userspace onlines CPU via sysfs. Signed-off-by: Igor Mammedov Acked-by: Toshi Kani Signed-off-by: Rafael J. Wysocki Signed-off-by: Jiri Slaby --- diff --git a/drivers/acpi/acpi_processor.c b/drivers/acpi/acpi_processor.c index f29e06efa479..f99cb6a15c00 100644 --- a/drivers/acpi/acpi_processor.c +++ b/drivers/acpi/acpi_processor.c @@ -410,7 +410,6 @@ static int acpi_processor_add(struct acpi_device *device, goto err; pr->dev = dev; - dev->offline = pr->flags.need_hotplug_init; /* Trigger the processor driver's .probe() if present. */ if (device_attach(dev) >= 0)