From: Tommi Rantala <tommi.t.rantala@nokia.com>
Date: Wed, 22 Mar 2017 13:06:22 +0000 (+0200)
Subject: perf utils: use sizeof(buf) - 1 in readlink() call
X-Git-Tag: v4.12-rc1~152^2~32^2~2
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=b7126ef78612a3d4a37aadf39125cff048cebb9b;p=platform%2Fkernel%2Flinux-exynos.git

perf utils: use sizeof(buf) - 1 in readlink() call

Ensure that we have space for the null byte in buf.

Signed-off-by: Tommi Rantala <tommi.t.rantala@nokia.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/20170322130624.21881-5-tommi.t.rantala@nokia.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---

diff --git a/tools/perf/util/header.c b/tools/perf/util/header.c
index 05714d5..cf22962 100644
--- a/tools/perf/util/header.c
+++ b/tools/perf/util/header.c
@@ -378,7 +378,7 @@ static int write_cmdline(int fd, struct perf_header *h __maybe_unused,
 	 * actual atual path to perf binary
 	 */
 	sprintf(proc, "/proc/%d/exe", getpid());
-	ret = readlink(proc, buf, sizeof(buf));
+	ret = readlink(proc, buf, sizeof(buf) - 1);
 	if (ret <= 0)
 		return -1;