From: Joe Gregorio Date: Fri, 3 Mar 2017 18:21:26 +0000 (-0500) Subject: Remove extract_comments in housekeeper bot. X-Git-Tag: accepted/tizen/5.0/unified/20181102.025319~46^2~741 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=b7115c68baef47b88f70b14d408e6cf5fab523f7;p=platform%2Fupstream%2FlibSkiaSharp.git Remove extract_comments in housekeeper bot. BUG=skia: Change-Id: I6bd745a03c9f8c06ed711839a4bda1db0693cf5a Reviewed-on: https://skia-review.googlesource.com/9220 Reviewed-by: Cary Clark Commit-Queue: Joe Gregorio --- diff --git a/infra/bots/recipes/swarm_housekeeper.expected/Housekeeper-PerCommit-Trybot.json b/infra/bots/recipes/swarm_housekeeper.expected/Housekeeper-PerCommit-Trybot.json index c526be0..7a58999 100644 --- a/infra/bots/recipes/swarm_housekeeper.expected/Housekeeper-PerCommit-Trybot.json +++ b/infra/bots/recipes/swarm_housekeeper.expected/Housekeeper-PerCommit-Trybot.json @@ -128,44 +128,6 @@ "name": "generate and upload binary size data" }, { - "cmd": [ - "[START_DIR]/go/go/bin/go", - "get", - "go.skia.org/infra/comments/go/extract_comments" - ], - "cwd": "[CUSTOM_/_B_WORK]/skia", - "env": { - "BUILDTYPE": "Release", - "CHROME_HEADLESS": "1", - "GIT_HTTP_LOW_SPEED_LIMIT": "1000", - "GIT_HTTP_LOW_SPEED_TIME": "300", - "GOPATH": "[START_DIR]/tmp/golib", - "PATH": "%(PATH)s:RECIPE_PACKAGE_REPO[depot_tools]", - "SKIA_OUT": "[START_DIR]/out" - }, - "name": "compile extract_comments" - }, - { - "cmd": [ - "[START_DIR]/tmp/golib/bin/extract_comments", - "--dir", - "gm", - "--dest", - "gs://skia-doc/gm/comments.json" - ], - "cwd": "[CUSTOM_/_B_WORK]/skia", - "env": { - "BUILDTYPE": "Release", - "CHROME_HEADLESS": "1", - "GIT_HTTP_LOW_SPEED_LIMIT": "1000", - "GIT_HTTP_LOW_SPEED_TIME": "300", - "GOPATH": "[START_DIR]/tmp/golib", - "PATH": "%(PATH)s:RECIPE_PACKAGE_REPO[depot_tools]", - "SKIA_OUT": "[START_DIR]/out" - }, - "name": "run extract_comments" - }, - { "name": "$result", "recipe_result": null, "status_code": 0 diff --git a/infra/bots/recipes/swarm_housekeeper.expected/Housekeeper-PerCommit.json b/infra/bots/recipes/swarm_housekeeper.expected/Housekeeper-PerCommit.json index 1071746..addd7d4 100644 --- a/infra/bots/recipes/swarm_housekeeper.expected/Housekeeper-PerCommit.json +++ b/infra/bots/recipes/swarm_housekeeper.expected/Housekeeper-PerCommit.json @@ -138,44 +138,6 @@ "name": "generate and upload binary size data" }, { - "cmd": [ - "[START_DIR]/go/go/bin/go", - "get", - "go.skia.org/infra/comments/go/extract_comments" - ], - "cwd": "[CUSTOM_/_B_WORK]/skia", - "env": { - "BUILDTYPE": "Release", - "CHROME_HEADLESS": "1", - "GIT_HTTP_LOW_SPEED_LIMIT": "1000", - "GIT_HTTP_LOW_SPEED_TIME": "300", - "GOPATH": "[START_DIR]/tmp/golib", - "PATH": "%(PATH)s:RECIPE_PACKAGE_REPO[depot_tools]", - "SKIA_OUT": "[START_DIR]/out" - }, - "name": "compile extract_comments" - }, - { - "cmd": [ - "[START_DIR]/tmp/golib/bin/extract_comments", - "--dir", - "gm", - "--dest", - "gs://skia-doc/gm/comments.json" - ], - "cwd": "[CUSTOM_/_B_WORK]/skia", - "env": { - "BUILDTYPE": "Release", - "CHROME_HEADLESS": "1", - "GIT_HTTP_LOW_SPEED_LIMIT": "1000", - "GIT_HTTP_LOW_SPEED_TIME": "300", - "GOPATH": "[START_DIR]/tmp/golib", - "PATH": "%(PATH)s:RECIPE_PACKAGE_REPO[depot_tools]", - "SKIA_OUT": "[START_DIR]/out" - }, - "name": "run extract_comments" - }, - { "name": "$result", "recipe_result": null, "status_code": 0 diff --git a/infra/bots/recipes/swarm_housekeeper.py b/infra/bots/recipes/swarm_housekeeper.py index cd7ef3d..1b9513c 100644 --- a/infra/bots/recipes/swarm_housekeeper.py +++ b/infra/bots/recipes/swarm_housekeeper.py @@ -57,29 +57,6 @@ def RunSteps(api): cwd=cwd, abort_on_failure=False) - env = {} - env['GOPATH'] = api.vars.tmp_dir.join('golib') - extractexe = env['GOPATH'].join('bin', 'extract_comments') - goexe = api.vars.slave_dir.join('go', 'go', 'bin', 'go') - - # Compile extract_comments. - api.run( - api.step, - 'compile extract_comments', - cmd=[goexe, 'get', 'go.skia.org/infra/comments/go/extract_comments'], - cwd=cwd, - env=env, - abort_on_failure=True) - - # Run extract_comments on the gm directory. - api.run( - api.step, - 'run extract_comments', - cmd=[extractexe, '--dir', 'gm', '--dest', 'gs://skia-doc/gm/comments.json'], - cwd=cwd, - env=env, - abort_on_failure=True) - def GenTests(api): yield (