From: Christophe JAILLET Date: Sat, 15 Jan 2022 07:24:20 +0000 (+0100) Subject: dmaengine: idxd: Remove useless DMA-32 fallback configuration X-Git-Tag: v6.6.17~7851^2~5 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=b6f2f0352c0302076dcd0e0297592ea7d37f2242;p=platform%2Fkernel%2Flinux-rpi.git dmaengine: idxd: Remove useless DMA-32 fallback configuration As stated in [1], dma_set_mask() with a 64-bit mask never fails if dev->dma_mask is non-NULL. So, if it fails, the 32 bits case will also fail for the same reason. Simplify code and remove some dead code accordingly. [1]: https://lore.kernel.org/linux-kernel/YL3vSPK5DXTNvgdx@infradead.org/#t Signed-off-by: Christophe JAILLET Acked-by: Dave Jiang Link: https://lore.kernel.org/r/009c80294dba72858cd8a6ed2ed81041df1b1e82.1642231430.git.christophe.jaillet@wanadoo.fr Signed-off-by: Vinod Koul --- diff --git a/drivers/dma/idxd/init.c b/drivers/dma/idxd/init.c index 08a5f43..993a5dc 100644 --- a/drivers/dma/idxd/init.c +++ b/drivers/dma/idxd/init.c @@ -605,8 +605,6 @@ static int idxd_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id) dev_dbg(dev, "Set DMA masks\n"); rc = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(64)); if (rc) - rc = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32)); - if (rc) goto err; dev_dbg(dev, "Set PCI master\n");