From: Axel Lin Date: Mon, 14 Apr 2014 07:30:41 +0000 (+0800) Subject: gpio: max730x: Remove kfree(ts) in __max730x_remove() X-Git-Tag: v3.16-rc1~30^2~53^2~67 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=b6d71fdbab9db265454e99b480081acc971dea59;p=platform%2Fkernel%2Flinux-exynos.git gpio: max730x: Remove kfree(ts) in __max730x_remove() The memory for ts is allocated by devm_kzalloc now, so the kfree is not required. Signed-off-by: Axel Lin Acked-by: Juergen Beisert Reviewed-by: Jingoo Han Signed-off-by: Linus Walleij --- diff --git a/drivers/gpio/gpio-max730x.c b/drivers/gpio/gpio-max730x.c index 8672755..0814584 100644 --- a/drivers/gpio/gpio-max730x.c +++ b/drivers/gpio/gpio-max730x.c @@ -237,10 +237,9 @@ int __max730x_remove(struct device *dev) ts->write(dev, 0x04, 0x00); ret = gpiochip_remove(&ts->chip); - if (!ret) { + if (!ret) mutex_destroy(&ts->lock); - kfree(ts); - } else + else dev_err(dev, "Failed to remove GPIO controller: %d\n", ret); return ret;