From: Father Chrysostomos <sprout@cpan.org>
Date: Thu, 12 Jan 2012 21:33:24 +0000 (-0800)
Subject: Simplify logic in pp_sys.c:pp_fttty
X-Git-Tag: accepted/trunk/20130322.191538~1264
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=b6cb94c5b90e1d814bbb4b070425ee261df0ce7e;p=platform%2Fupstream%2Fperl.git

Simplify logic in pp_sys.c:pp_fttty

name is only set when there is no gv.  As of a couple of commits ago,
tmpsv is only used in that else block where it is set.
---

diff --git a/pp_sys.c b/pp_sys.c
index 0131a2e..b8c212c 100644
--- a/pp_sys.c
+++ b/pp_sys.c
@@ -3248,7 +3248,6 @@ PP(pp_fttty)
     dSP;
     int fd;
     GV *gv;
-    SV *tmpsv = NULL;
     char *name = NULL;
     STRLEN namelen;
 
@@ -3259,7 +3258,7 @@ PP(pp_fttty)
     if (PL_op->op_flags & OPf_REF)
 	gv = cGVOP_gv;
     else {
-      tmpsv = POPs;
+      SV *tmpsv = POPs;
       if (!(gv = MAYBE_DEREF_GV_nomg(tmpsv))) {
 	name = SvPV_nomg(tmpsv, namelen);
 	gv = gv_fetchpvn_flags(name, namelen, SvUTF8(tmpsv), SVt_PVIO);
@@ -3268,12 +3267,8 @@ PP(pp_fttty)
 
     if (GvIO(gv) && IoIFP(GvIOp(gv)))
 	fd = PerlIO_fileno(IoIFP(GvIOp(gv)));
-    else if (!gv && SvOK(tmpsv)) {
-	if (isDIGIT(*name))
+    else if (name && isDIGIT(*name))
 	    fd = atoi(name);
-	else 
-	    RETPUSHUNDEF;
-    }
     else
 	RETPUSHUNDEF;
     if (PerlLIO_isatty(fd))