From: Karl Williamson Date: Sat, 12 Oct 2013 04:54:36 +0000 (-0600) Subject: podcheck.t: Make blead pass again X-Git-Tag: upstream/5.20.0~1577 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=b68084b8883aecdacceb57c6c6566503ba6a0fdd;p=platform%2Fupstream%2Fperl.git podcheck.t: Make blead pass again Blead is failing sometimes on podcheck.t. I don't fully understand the reasons, but it is some sort of race condition. The base problem that is causing this race to show up is a bug in the new version 3.29 of Test::Harness. It includes 2 pods that have the same name. This creates problems for reading the documentation in an html browser. The software that creates the hyperlinks uses the pod name to figure out what the linked-to document is. It cannot figure out which one to link to when multiple pods have the same name, as here, so podcheck raises an error. Test::Harness should change so that the pods have different names. It's like having two different Unix commands named 'foobar'. Which one should `man foobar` display, if it could only display one? I haven't figured out how to fix the race yet, so this commit just ignores one of the conflicting files for now. The race has something to do with the fact that these are both cpan files which are not normally examined for pod problems, and so the error for one of them is getting suppressed; and which one of the two gets suppressed varies. This bug in Test::Harness also manifested itself as showing up a broken link. --- diff --git a/t/porting/known_pod_issues.dat b/t/porting/known_pod_issues.dat index a558833..50449aa 100644 --- a/t/porting/known_pod_issues.dat +++ b/t/porting/known_pod_issues.dat @@ -227,7 +227,6 @@ pod/perlcygwin.pod Verbatim line length including indents exceeds 79 by 25 pod/perldebguts.pod Verbatim line length including indents exceeds 79 by 34 pod/perldebtut.pod Verbatim line length including indents exceeds 79 by 22 pod/perldebug.pod Verbatim line length including indents exceeds 79 by 3 -pod/perldelta.pod Apparent broken link 1 pod/perldsc.pod Verbatim line length including indents exceeds 79 by 4 pod/perldtrace.pod Verbatim line length including indents exceeds 79 by 26 pod/perlebcdic.pod Verbatim line length including indents exceeds 79 by 3 @@ -237,7 +236,6 @@ pod/perlgpl.pod Verbatim line length including indents exceeds 79 by 50 pod/perlguts.pod ? Should you be using F<...> or maybe L<...> instead of 2 pod/perlguts.pod ? Should you be using L<...> instead of 1 pod/perlhack.pod ? Should you be using L<...> instead of 1 -pod/perlhack.pod Apparent broken link 1 pod/perlhist.pod Verbatim line length including indents exceeds 79 by 1 pod/perlhpux.pod Verbatim line length including indents exceeds 79 by 5 pod/perlhurd.pod Verbatim line length including indents exceeds 79 by 2 @@ -279,4 +277,3 @@ lib/config.pod ? Should you be using L<...> instead of -1 lib/extutils/embed.pm Verbatim line length including indents exceeds 79 by 2 lib/perl5db.pl ? Should you be using L<...> instead of 1 lib/pod/text/overstrike.pm Verbatim line length including indents exceeds 79 by 1 -lib/test/harness.pm Pod NAME already used 1 diff --git a/t/porting/podcheck.t b/t/porting/podcheck.t index 8fc674c..26d589b 100644 --- a/t/porting/podcheck.t +++ b/t/porting/podcheck.t @@ -389,6 +389,8 @@ my %excluded_files = ( canonicalize('cpan/Pod-Perldoc/corpus/perlfunc.pod') => 1, canonicalize('cpan/Pod-Perldoc/corpus/utf8.pod') => 1, canonicalize("lib/unicore/mktables") => 1, + canonicalize("cpan/Test-Harness/lib/TAP/Harness/Beyond.pod") => 1, #XXX temporary to get blead passing + canonicalize("lib/TAP/Harness/Beyond.pod") => 1, #XXX temporary to get blead passing ); # This list should not include anything for which case sensitivity is