From: Bruce Forstall Date: Tue, 7 May 2019 18:06:28 +0000 (-0700) Subject: Fix build.cmd passing of args to runtest.cmd X-Git-Tag: submit/tizen/20210909.063632~11030^2~1604^2 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=b65e5c31824a81ac60bc68ab45b1989edc112870;p=platform%2Fupstream%2Fdotnet%2Fruntime.git Fix build.cmd passing of args to runtest.cmd If you use the `generatelayout` argument to build.cmd, it passes all "unprocessed" arguments directly on to msbuild. To accomplish the same this with runtest.cmd, you must use the "msbuildargs" argument, or else the arg will be treated as a `CORE_ROOT` argument. (This seems like a bad design, but that's a separate issue.) E.g., I always pass `/consoleloggerparameters:ForceNoAlign`, and want that passed on to runtest.cmd. (This should also be the default, but once again, that's a separate issue.) Commit migrated from https://github.com/dotnet/coreclr/commit/935d2fa6e6e785412678c5b389e69d6cdec4c275 --- diff --git a/src/coreclr/build.cmd b/src/coreclr/build.cmd index bd6d355..ae2ca0e 100644 --- a/src/coreclr/build.cmd +++ b/src/coreclr/build.cmd @@ -904,7 +904,7 @@ if %__BuildTests% EQU 1 ( ) else if %__GenerateLayout% EQU 1 ( echo %__MsgPrefix%Generating layout for %__BuildOS%.%__BuildArch%.%__BuildType% - set NEXTCMD=call %__ProjectDir%\tests\runtest.cmd %__BuildArch% %__BuildType% GenerateLayoutOnly %__UnprocessedBuildArgs% + set NEXTCMD=call %__ProjectDir%\tests\runtest.cmd %__BuildArch% %__BuildType% GenerateLayoutOnly msbuildargs %__UnprocessedBuildArgs% echo %__MsgPrefix%!NEXTCMD! !NEXTCMD!