From: Alan Jenkins Date: Thu, 24 Aug 2017 14:21:21 +0000 (+0100) Subject: logind: tighten assertion in execute_shutdown_or_sleep() X-Git-Tag: v235~192^2 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=b61fa4e00166b2bf593e0f6edbb277543f03915f;p=platform%2Fupstream%2Fsystemd.git logind: tighten assertion in execute_shutdown_or_sleep() Following commit b498d6ea, I belated realized we should tighten the assertions as well, to make sure that we're setting `m->action_what` to represent an action in progress. (The check for an action in progress is to compare `m->action_what` to zero) --- diff --git a/src/login/logind-dbus.c b/src/login/logind-dbus.c index 77dd278..d66022f 100644 --- a/src/login/logind-dbus.c +++ b/src/login/logind-dbus.c @@ -1514,7 +1514,7 @@ static int execute_shutdown_or_sleep( int r; assert(m); - assert(w >= 0); + assert(w > 0); assert(w < _INHIBIT_WHAT_MAX); assert(unit_name); @@ -1661,7 +1661,7 @@ int bus_manager_shutdown_or_sleep_now_or_later( assert(m); assert(unit_name); - assert(w >= 0); + assert(w > 0); assert(w <= _INHIBIT_WHAT_MAX); assert(!m->action_job);