From: Dan Carpenter Date: Mon, 22 Jul 2013 06:56:54 +0000 (+0300) Subject: ASoC: core: double free in snd_soc_add_platform() X-Git-Tag: upstream/snapshot3+hdmi~4491^2~16^2~4^2 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=b5c745fb75b7e5ab06e9c99d63427595a234cc89;p=platform%2Fadaptation%2Frenesas_rcar%2Frenesas_kernel.git ASoC: core: double free in snd_soc_add_platform() There are three callers for this function, and none of them want it to free platform for them. It leads to a double free. Signed-off-by: Dan Carpenter Signed-off-by: Mark Brown --- diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c index 0ec070c..d82ee38 100644 --- a/sound/soc/soc-core.c +++ b/sound/soc/soc-core.c @@ -3908,10 +3908,8 @@ int snd_soc_add_platform(struct device *dev, struct snd_soc_platform *platform, { /* create platform component name */ platform->name = fmt_single_name(dev, &platform->id); - if (platform->name == NULL) { - kfree(platform); + if (platform->name == NULL) return -ENOMEM; - } platform->dev = dev; platform->driver = platform_drv;