From: Alex Elder Date: Thu, 2 May 2013 02:37:07 +0000 (-0500) Subject: rbd: fix image request leak on parent read X-Git-Tag: v3.10~8^2~41 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=b5b09be30cf99f9c699e825629f02e3bce555d44;p=platform%2Fkernel%2Flinux-exynos.git rbd: fix image request leak on parent read When a read for a layered image object finds the target object doesn't exist, a read image request for the parent image is created and submitted. When that completes, the callback routine was not releasing that parent image request. Fix that. The slab allocation stuff just added has greatly simplified the search for the source of this memory leak. This resolves: http://tracker.ceph.com/issues/4803 Signed-off-by: Alex Elder Reviewed-by: Josh Durgin --- diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c index 390946a..c2ca181 100644 --- a/drivers/block/rbd.c +++ b/drivers/block/rbd.c @@ -2547,6 +2547,7 @@ static void rbd_img_parent_read_callback(struct rbd_img_request *img_request) obj_request->xferred = img_request->xferred; } out: + rbd_img_request_put(img_request); rbd_img_obj_request_read_callback(obj_request); rbd_obj_request_complete(obj_request); }