From: Markus Elfring <elfring@users.sourceforge.net>
Date: Mon, 1 Dec 2014 21:55:29 +0000 (-0300)
Subject: [media] mn88473: Remove uneeded check before release_firmware()
X-Git-Tag: v4.9.8~4959^2~27
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=b59113845f76b8b21946563ee538a580fc972c6c;p=platform%2Fkernel%2Flinux-rpi3.git

[media] mn88473: Remove uneeded check before release_firmware()

The release_firmware() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
---

diff --git a/drivers/staging/media/mn88473/mn88473.c b/drivers/staging/media/mn88473/mn88473.c
index 1659335..52180bb 100644
--- a/drivers/staging/media/mn88473/mn88473.c
+++ b/drivers/staging/media/mn88473/mn88473.c
@@ -262,8 +262,7 @@ static int mn88473_init(struct dvb_frontend *fe)
 
 	return 0;
 err:
-	if (fw)
-		release_firmware(fw);
+	release_firmware(fw);
 
 	dev_dbg(&client->dev, "failed=%d\n", ret);
 	return ret;