From: Tejun Heo <tj@kernel.org>
Date: Mon, 2 Mar 2009 09:55:16 +0000 (+0900)
Subject: libata: don't use on-stack sense buffer
X-Git-Tag: v2.6.29-rc8~63^2~4
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=b53570814692db79c3525523b6e9ec9874416c04;p=platform%2Fupstream%2Fkernel-adaptation-pc.git

libata: don't use on-stack sense buffer

sense_buffer is used as DMA target and shouldn't be allocated on
stack.  Use ap->sector_buf instead.  This problem is spotted by Chuck
Ebbert.

Signed-off-by: Tejun Heo <tj@kernel.org>
Reported-by: Chuck Ebbert <cebbert@redhat.com>
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
---

diff --git a/drivers/ata/libata-eh.c b/drivers/ata/libata-eh.c
index ce2ef04..009ccc7 100644
--- a/drivers/ata/libata-eh.c
+++ b/drivers/ata/libata-eh.c
@@ -2901,7 +2901,7 @@ static int atapi_eh_clear_ua(struct ata_device *dev)
 	int i;
 
 	for (i = 0; i < ATA_EH_UA_TRIES; i++) {
-		u8 sense_buffer[SCSI_SENSE_BUFFERSIZE];
+		u8 *sense_buffer = dev->link->ap->sector_buf;
 		u8 sense_key = 0;
 		unsigned int err_mask;