From: Ilho Kim <ilho159.kim@samsung.com>
Date: Mon, 15 Mar 2021 06:04:38 +0000 (+0900)
Subject: Fix memory leak
X-Git-Tag: submit/tizen/20210317.082331~21
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=b495ff1989320d329ab46c9f97613a0e4ae6eb36;p=platform%2Fcore%2Fappfw%2Fpkgmgr-info.git

Fix memory leak

Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
---

diff --git a/src/common/parcel/depinfo_parcelable.cc b/src/common/parcel/depinfo_parcelable.cc
index fc2149a..28947e8 100644
--- a/src/common/parcel/depinfo_parcelable.cc
+++ b/src/common/parcel/depinfo_parcelable.cc
@@ -61,7 +61,7 @@ const std::string& DepInfoParcelable::GetPkgID() {
 
 void DepInfoParcelable::WriteToParcel(tizen_base::Parcel* parcel) const {
   AbstractParcelable::WriteToParcel(parcel);
-  WriteString(parcel, pkgid_.c_str());
+  parcel->WriteString(pkgid_);
   WriteInt(parcel, dependency_list_.size());
 
   for (auto dependency : dependency_list_) {
@@ -73,8 +73,7 @@ void DepInfoParcelable::ReadFromParcel(tizen_base::Parcel* parcel) {
   int len = 0;
   char *pkgid;
   AbstractParcelable::ReadFromParcel(parcel);
-  ReadString(parcel, &pkgid);
-  pkgid_ = std::string(pkgid);
+  pkgid_ = parcel->ReadString();
   ReadInt(parcel, &len);
 
   for (int i = 0; i < len ; ++i) {
diff --git a/src/pkgmgrinfo_pkginfo.c b/src/pkgmgrinfo_pkginfo.c
index 60c67bb..1bdb55f 100644
--- a/src/pkgmgrinfo_pkginfo.c
+++ b/src/pkgmgrinfo_pkginfo.c
@@ -238,18 +238,12 @@ API int pkgmgrinfo_pkginfo_get_usr_pkginfo(const char *pkgid, uid_t uid,
 {
 	int ret;
 	pkgmgrinfo_pkginfo_filter_h filter;
-	GHashTable *list;
 
 	if (pkgid == NULL || handle == NULL) {
 		LOGE("invalid parameter");
 		return PMINFO_R_EINVAL;
 	}
 
-	list = g_hash_table_new_full(g_str_hash, g_str_equal, NULL,
-			__free_packages);
-	if (list == NULL)
-		return PMINFO_R_ERROR;
-
 	ret = pkgmgrinfo_pkginfo_filter_create(&filter);
 	if (ret != PMINFO_R_OK)
 		return ret;