From: Doug Nazar <nazard@nazar.ca>
Date: Tue, 3 Sep 2019 03:25:39 +0000 (-0400)
Subject: audio-resampler: Update NEON to handle remainders not multiples of 4
X-Git-Tag: 1.16.2~30
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=b47b2f868dd6674bce950a9adcbd50ba61588aae;p=platform%2Fupstream%2Fgst-plugins-base.git

audio-resampler: Update NEON to handle remainders not multiples of 4

If the remainder is not evenly divisable by 4, we'd miss the check
for zero and continue the loop until crashing. Change the branch
to take into account negatives as well.

This more closely matches the SSE loop.
---

diff --git a/gst-libs/gst/audio/audio-resampler-neon.h b/gst-libs/gst/audio/audio-resampler-neon.h
index 5863e18..5a77d45 100644
--- a/gst-libs/gst/audio/audio-resampler-neon.h
+++ b/gst-libs/gst/audio/audio-resampler-neon.h
@@ -46,7 +46,7 @@ inner_product_gint16_full_1_neon (gint16 * o, const gint16 * a,
                   "      vld1.16 {d20}, [%[a]]!\n"
                   "      subs %[remainder], %[remainder], #4\n"
                   "      vmlal.s16 q0, d16, d20\n"
-                  "      bne 3b\n"
+                  "      bgt 3b\n"
                   "4:"
                   "      vadd.s32 d0, d0, d1\n"
                   "      vpadd.s32 d0, d0, d0\n"
@@ -97,7 +97,7 @@ inner_product_gint16_linear_1_neon (gint16 * o, const gint16 * a,
                   "      subs %[remainder], %[remainder], #4\n"
                   "      vmlal.s16 q0, d16, d24\n"
                   "      vmlal.s16 q1, d20, d24\n"
-                  "      bne 3b\n"
+                  "      bgt 3b\n"
                   "4:"
                   "      vld2.16 {d20[], d21[]}, [%[ic]]\n"
                   "      vshrn.s32 d0, q0, #15\n"
@@ -272,7 +272,7 @@ inner_product_gint32_full_1_neon (gint32 * o, const gint32 * a,
                   "      subs %[remainder], %[remainder], #4\n"
                   "      vmlal.s32 q0, d16, d20\n"
                   "      vmlal.s32 q0, d17, d21\n"
-                  "      bne 3b\n"
+                  "      bgt 3b\n"
                   "4:"
                   "      vadd.s64 d0, d0, d1\n"
                   "      vqrshrn.s64 d0, q0, #31\n"
@@ -487,7 +487,7 @@ inner_product_gfloat_full_1_neon (gfloat * o, const gfloat * a,
                   "      vld1.32 {q10}, [%[a]]!\n"
                   "      subs %[remainder], %[remainder], #4\n"
                   "      vmla.f32 q0, q6, q10\n"
-                  "      bne 3b\n"
+                  "      bgt 3b\n"
                   "4:"
                   "      vadd.f32 d0, d0, d1\n"
                   "      vpadd.f32 d0, d0, d0\n"