From: Dinghao Liu <dinghao.liu@zju.edu.cn>
Date: Mon, 25 May 2020 13:02:06 +0000 (+0200)
Subject: media: coda: Fix runtime PM imbalance in coda_probe
X-Git-Tag: v5.15~2723^2~143
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=b4630215067a411341ceeb7850b95b341eee6511;p=platform%2Fkernel%2Flinux-starfive.git

media: coda: Fix runtime PM imbalance in coda_probe

When coda_firmware_request() returns an error code,
a pairing runtime PM usage counter decrement is needed
to keep the counter balanced.

Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
---

diff --git a/drivers/media/platform/coda/coda-common.c b/drivers/media/platform/coda/coda-common.c
index eeba6c0..87a2c70 100644
--- a/drivers/media/platform/coda/coda-common.c
+++ b/drivers/media/platform/coda/coda-common.c
@@ -3264,6 +3264,8 @@ static int coda_probe(struct platform_device *pdev)
 	return 0;
 
 err_alloc_workqueue:
+	pm_runtime_disable(&pdev->dev);
+	pm_runtime_put_noidle(&pdev->dev);
 	destroy_workqueue(dev->workqueue);
 err_v4l2_register:
 	v4l2_device_unregister(&dev->v4l2_dev);