From: Dan Carpenter Date: Fri, 20 Apr 2012 19:16:54 +0000 (-0700) Subject: [SCSI] fcoe: remove a stray unlock X-Git-Tag: v3.5-rc1~172^2~53 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=b3b8abd85780e1bb92703354f3c16c921edfa4f6;p=profile%2Fivi%2Fkernel-x86-ivi.git [SCSI] fcoe: remove a stray unlock We moved the locking in dd060e74fb "[SCSI] fcoe: remove frame dropping code from fcoe_percpu_clean" but this unlock was missed. Signed-off-by: Dan Carpenter Signed-off-by: Robert Love Signed-off-by: James Bottomley --- diff --git a/drivers/scsi/fcoe/fcoe.c b/drivers/scsi/fcoe/fcoe.c index ac1df93..76e3d0b 100644 --- a/drivers/scsi/fcoe/fcoe.c +++ b/drivers/scsi/fcoe/fcoe.c @@ -2294,10 +2294,9 @@ static void fcoe_percpu_clean(struct fc_lport *lport) continue; skb = dev_alloc_skb(0); - if (!skb) { - spin_unlock_bh(&pp->fcoe_rx_list.lock); + if (!skb) continue; - } + skb->destructor = fcoe_percpu_flush_done; spin_lock_bh(&pp->fcoe_rx_list.lock);